[example] add dev and preview for esbuild example#1227
Open
RavenColEvol wants to merge 1 commit intofacebook:mainfrom
Open
[example] add dev and preview for esbuild example#1227RavenColEvol wants to merge 1 commit intofacebook:mainfrom
RavenColEvol wants to merge 1 commit intofacebook:mainfrom
Conversation
Collaborator
|
This change will take a little longer for me to review because I'm not super familiar with how esbuild works, but things look pretty good so far. Thank you! |
Contributor
Author
|
Sure @nmn I'm also not super familiar with esbuild. What I did was kept these requirements in mind and simply started exploring how it can be achieved in esbuild through there documentation. Requirements:
|
|
Sorry to butt in here, but curious as I have recently been working in an app that uses ESBuild and StyleX. I thought the StyleX ESBuild plugin was deprecated? Nice work adding in a watch btw. |
f0aa732 to
63da92c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
I was just going over the repo to see if I can make any contribution. Found that esbuild example doesn't have any way for me to preview the build or do dev changes.
Linked PR/Issues
Fixes # (issue)
Additional Context
Screenshots, Tests, Anything Else
https://github.com/user-attachments/assets/ce55b1ac-cba1-4844-b7a7-c9e5e620eb8b
Pre-flight checklist
Contribution Guidelines