[types] cursor should accept arbitrary string #1466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
This updates the
CSSCursortype to accept arbitrary strings to address a recent bug report. The fix in this PR is to simply addstringto the union type.I personally would prefer the TypeScript union to include
| (string & {})for the improved autocomplete but right now we are generating types from Flow. This article explains the TypeScript trick in more detail. Any objections to maintaining a separate type definitions of the CSS Types so we could use that trick? Have you considered directly usingcsstype?Linked PR/Issues
Fixes #1463
Screenshots, Tests, Anything Else
Pre-flight checklist
Contribution Guidelines