Skip to content

Conversation

@henryqdineen
Copy link
Collaborator

What changed / motivation ?

This updates the CSSCursor type to accept arbitrary strings to address a recent bug report. The fix in this PR is to simply add string to the union type.

I personally would prefer the TypeScript union to include | (string & {}) for the improved autocomplete but right now we are generating types from Flow. This article explains the TypeScript trick in more detail. Any objections to maintaining a separate type definitions of the CSS Types so we could use that trick? Have you considered directly using csstype?

Linked PR/Issues

Fixes #1463

Screenshots, Tests, Anything Else

Pre-flight checklist

@vercel
Copy link

vercel bot commented Jan 27, 2026

@henryqdineen is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

url value for cursor property

1 participant