Add more compelling custom marker example#1468
Merged
mellyeliu merged 1 commit intofacebook:mainfrom Jan 28, 2026
Merged
Conversation
The old example didn't quite demostrate the advantages of custom markers. I think this example demonstrates it better.
Daniel15
requested review from
ezzak,
mellyeliu,
necolas,
nmn and
vincentriemer
as code owners
|
@Daniel15 is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
bot
added
the
CLA Signed
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
mellyeliu
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
The old example didn't quite demostrate the advantages of custom markers. I think this example demonstrates it better. This is based on an actual use case in Ads Manager.
Linked PR/Issues
N/A
Additional Context
Playground
Pre-flight checklist
Contribution Guidelines