Fix multiple issues relating to async/await#358
Merged
rich-hansen merged 1 commit intofacebookincubator:mainfrom Sep 3, 2025
Merged
Fix multiple issues relating to async/await#358rich-hansen merged 1 commit intofacebookincubator:mainfrom
rich-hansen merged 1 commit intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
rich-hansen
reviewed
Sep 3, 2025
| "noFallthroughCasesInSwitch": true, | ||
| "strict": true, | ||
| "target": "ES6" | ||
| "target": "ES2017" |
Contributor
Author
There was a problem hiding this comment.
We can, I'll look into it as a follow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chrome.APIs in Firefox/Safari must usebrowser.this is why we haven't usually used these in the past. But I want to be able to use this syntax, so I've added some global logic to magically usebrowser.when it's available (non-chromium browsers) and fallback tochrome.when it's not, this will allow the Promise based APIs to always work..tsconfigstorage.getKeys()JUST got added to Firefox https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/143#changes_for_add-on_developers so I'm changing things to usestorage.get(null)instead since it has access to similar information