Upgrade eslint to match new typescript version#362
Merged
rich-hansen merged 1 commit intofacebookincubator:mainfrom Sep 4, 2025
Merged
Upgrade eslint to match new typescript version#362rich-hansen merged 1 commit intofacebookincubator:mainfrom
rich-hansen merged 1 commit intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
rich-hansen
reviewed
Sep 4, 2025
| const params = new URL(document.location.href).searchParams; | ||
| setUpBackgroundMessageHandler(params.get('tab_id')); | ||
| const state = params.get('state') as State; | ||
| state && updateDisplay(state); |
Contributor
There was a problem hiding this comment.
Why are we removing the state check here?
Contributor
Author
There was a problem hiding this comment.
Redundant because of the line above, eslint was complaining.
rich-hansen
reviewed
Sep 4, 2025
| try { | ||
| JSON.parse(nodeTextContent); | ||
| } catch (parseError) { | ||
| } catch { |
Contributor
There was a problem hiding this comment.
Neat, didn't realize they made exceptionVar optional.
rich-hansen
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade eslint version to match prior typescript bump