Maintain violations when tab ID is reused#363
Closed
ezzak wants to merge 2 commits intofacebookincubator:mainfrom
Closed
Maintain violations when tab ID is reused#363ezzak wants to merge 2 commits intofacebookincubator:mainfrom
ezzak wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
ezzak
force-pushed
the
tab_id_storage_changes
branch
from
17cb602 to
17f22e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Chrome tab ID would most likely be reused mostly on refresh, but Firefox tab Ids count upward from 1 so Ids are more likely to clash. In this case maintain the violations.