Skip to content

Fix SVGs again #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rich-hansen merged 1 commit into from
Sep 5, 2025
Merged

Fix SVGs again #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/css/popup.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ header {
.menu_button,
#close_button {
cursor: pointer;
display: flex;
}

.state_boundary {
Expand Down
5 changes: 2 additions & 3 deletions src/css/violations.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,10 @@ violation-list code {
box-sizing: border-box;
}

.download_img {
.download_button {
cursor: pointer;
opacity: 0.8;
width: 16px;
height: 16px;
display: inline-flex;
}

violation-list .subtable_wrapper.expanded {
Expand Down
50 changes: 39 additions & 11 deletions src/html/popup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,37 +48,65 @@
status-message="i18ndownloadSourceDescription"
primary-button-id="i18nDownloadSourceButton"
primary-button-action="download"></state-element>

<div class="state_boundary" id="menu">
<header>
<span class="header_title">
<img src="default_32.png" width="20px" height="20px" />
<p class="header_label" id="i18nTopLevel"></p>
</span>
<img id="close_button" height="20px" width="20px" src="x.svg" />
<span id="close_button">
<object
height="20px"
width="20px"
type="image/svg+xml"
data="x.svg" /></object>
</span>
</header>

<div class="menu_top_level">
<div class="menu_right_sidebar">
<div class="menu_row">
<img src="circle-info.svg" height="20px" />
<object
type="image/svg+xml"
data="circle-info.svg"
height="20px"></object>
<p id="i18nTopLevelLearnMore"></p>
<img src="chevron-right.svg" height="16px" />
<object
type="image/svg+xml"
data="chevron-right.svg"
height="16px"></object>
</div>
<div class="menu_row">
<img src="circle-info.svg" height="20px" />
<object
type="image/svg+xml"
data="circle-info.svg"
height="20px"></object>
<p id="i18nViewAllViolations"></p>
<img src="chevron-right.svg" height="16px" />
<object
type="image/svg+xml"
data="chevron-right.svg"
height="16px"></object>
</div>
<div class="menu_row">
<img src="circle-download-cta.svg" height="20px" />
<object
type="image/svg+xml"
data="circle-download-cta.svg"
height="20px"></object>
<p id="i18ndownloadSourcePrompt"></p>
<img src="chevron-right.svg" height="16px" />
<object
type="image/svg+xml"
data="chevron-right.svg"
height="16px"></object>
</div>
<div class="menu_row">
<img src="circle-download-cta.svg" height="20px" />
<object
type="image/svg+xml"
data="circle-download-cta.svg"
height="20px"></object>
<p id="i18ndownloadReleaseSourcePrompt"></p>
<img src="chevron-right.svg" height="16px" />
<object
type="image/svg+xml"
data="chevron-right.svg"
height="16px"></object>
</div>
</div>
</div>
Expand Down
17 changes: 10 additions & 7 deletions src/js/popup/popup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,13 @@ class PopupHeader extends HTMLElement {
: ''
}
</span>
<img
class="menu_button"
height="20px"
width="20px"
src="menu-badge.svg" />
<span class="menu_button">
<object
type="image/svg+xml"
height="20px"
width="20px"
data="menu-badge.svg"></object>
</span>
</header>
`;

Expand Down Expand Up @@ -231,9 +233,10 @@ class StateElement extends HTMLElement {
<div class="content_body">
${
type
? `<img
? `<object
class="body_image"
src="${type}-header.svg"/>`
type="image/svg+xml"
data="${type}-header.svg"></object>`
: ''
}
${
Expand Down
13 changes: 9 additions & 4 deletions src/js/popup/violation-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,16 @@ class ViolationList extends HTMLElement {
<td>${v.version}</td>
<td>${v.origin}</td>
<td>
<img
class="download_img"
<span
data-tab-id="${tabID}"
data-hash="${v.hash}"
src="circle-download-cta.svg"/>
class="download_button">
<object
type="image/svg+xml"
width="16px"
height="16px"
data="circle-download-cta.svg"></object>
</span>
</td>
</tr>
`;
Expand Down Expand Up @@ -100,7 +105,7 @@ class ViolationList extends HTMLElement {
</table>
`;

document.querySelectorAll('.download_img').forEach(img => {
document.querySelectorAll('.download_button').forEach(img => {
img.addEventListener('click', () => {
const tabID = img.getAttribute('data-tab-id')!;
const hash = img.getAttribute('data-hash')!;
Expand Down