Merged
Conversation
meta-cla
bot
added
the
CLA Signed
ezzak
force-pushed
the
fix_svgs_again
branch
from
b29b30f to
e30f293
Compare
ezzak
force-pushed
the
fix_svgs_again
branch
from
e30f293 to
096f612
Compare
rich-hansen
approved these changes
Sep 5, 2025
Contributor
rich-hansen
left a comment
rich-hansen
left a comment
There was a problem hiding this comment.
oops, everything old is new again. lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot why we need to use
<object />for SVGs https://github.com/facebookincubator/meta-code-verify/pull/313/filesAnd accidently got rid of them recently, this PR brings them back