Skip to content
This repository was archived by the owner on May 9, 2023. It is now read-only.

Comments

script to convert amass to bvh#81

Open
visonpon wants to merge 2 commits intofacebookresearch:mainfrom
visonpon:main
Open

script to convert amass to bvh#81
visonpon wants to merge 2 commits intofacebookresearch:mainfrom
visonpon:main

Conversation

@visonpon
Copy link

@visonpon visonpon commented Jul 1, 2022

No description provided.

@facebook-github-bot
Copy link

Hi @visonpon!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@dpacgopinath
Copy link
Contributor

Hi @visonpon , thank you for the pull request! I believe this is useful functionality since we can load the body model once and batch convert files. Since this is a standalone script, perhaps we could move this code to a new folder called scripts?

I have a left a few comments, mostly to parallelize the conversion and make the parameters configurable.

@visonpon
Copy link
Author

visonpon commented Jul 2, 2022

I'm glad it helps, just do as you like ~

Copy link

@duanheshu duanheshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, so the amass can be used more friendly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants