-
Notifications
You must be signed in to change notification settings - Fork 133
Fix sampling error with many pipelines when allow_repeats=False #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cbalioglu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! As we discussed offline, we can slightly simplify the code by reusing is_epoch_done_ for the purpose of checking blocked pipelines. Other than that, I only have a few nit comments.
a283216 to
469cff1
Compare
This reverts commit 4e1e62f.
5e2a418 to
8a4954e
Compare
cbalioglu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix!




What does this PR do? Please describe:
A summary of the change or the issue that is fixed.
Fixes #1472
Does your PR introduce any breaking changes? If yes, please list them:
List of all backwards-incompatible changes.
Check list: