-
Notifications
You must be signed in to change notification settings - Fork 133
HG - Hardware-specific sharding test and instructions with torchrun #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rsyue
wants to merge
39
commits into
main
Choose a base branch
from
rsy/hg-model-hardware-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del) and changed allowed patterns to allow for the json index file
…projs are sharded in fs2)
…d references; new hg doc added
… stub import for tqdm standalone
Contributor
Author
|
This is a PR to merge both the HuggingFace branch as well as a new hardware-specific test for sharding with multiple GPUs |
Contributor
Author
|
Module renamed to hg_qwen_omni and references updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please describe:
When more than 1 GPU present, model sharding can be tested with
torchrun --nproc-per-node 8 test_hg_factory.pyDoes your PR introduce any breaking changes? If yes, please list them:
None aware of
Check list: