Skip to content

Improve the implementation of share_parameters #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbalioglu merged 1 commit into from
Jan 9, 2026
Merged

Improve the implementation of share_parameters #1484

cbalioglu merged 1 commit into from
Jan 9, 2026

Conversation

@cbalioglu
Copy link
Contributor

@cbalioglu cbalioglu commented Jan 9, 2026

This PR improves the implementation of share_parameters and also makes sure it handles tied parameters correctly.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2026
@jasonppy
Copy link

jasonppy commented Jan 9, 2026

Thanks! have tested that it works

@cbalioglu cbalioglu merged commit a1f0c56 into main Jan 9, 2026
15 checks passed
@cbalioglu cbalioglu deleted the balioglu/share_params branch January 9, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cirquit cirquit Awaiting requested review from cirquit cirquit is a code owner

@MartinGleize MartinGleize Awaiting requested review from MartinGleize MartinGleize is a code owner

@zyaoj zyaoj Awaiting requested review from zyaoj zyaoj is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbalioglu @jasonppy