Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

desc | bugfix def_ph not defined#15

Open
Vulwsztyn wants to merge 1 commit intofacebookresearch:mainfrom
Vulwsztyn:def_ph_bugfix
Open

desc | bugfix def_ph not defined#15
Vulwsztyn wants to merge 1 commit intofacebookresearch:mainfrom
Vulwsztyn:def_ph_bugfix

Conversation

@Vulwsztyn
Copy link

@Vulwsztyn Vulwsztyn commented Aug 17, 2021 

        
        if pruning_strategy:
            pruning_hparams = ...
            if defaults and defaults.pruning_hparams.pruning_strategy == pruning_strategy:
                def_ph = defaults.pruning_hparams
        else:
            def_ph = None
            pruning_hparams = ...
        pruning_hparams.add_args(parser, defaults=def_ph if defaults else None)

this piece of code allowed def_ph not to be defined in the last line

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vulwsztyn @facebook-github-bot