Skip to content

Conversation

@cirquit
Copy link

@cirquit cirquit commented Oct 14, 2025

Why ?

Stopes is used with libraries that use fairseq2:v0.5+ and needs to be upgraded to play nice with them.
It would be optimal to create a new minor release by bumping the version here, build a new release candidate and upload the wheel to PyPi.

How ?

Upgraded the code that is loaded by default when initializing the library and bumped the fairseq2 version to >=v0.5. (42b28bb)

A few additional changes were required to make the CI happy again:

  • black==22.1 on the CI for some reason (v24 was a big change in default behavior) and I needed to align it (245936f)
  • isort was not happy as well, needed to update (245936f)
  • there was an async loop initialization issue when accessing it from a thread that does not have an event loop, replaced it with a generic solution that does not assume a loop is running to remove the RuntimeError: There is no current event loop in thread 'MainThread'. I suspect that this happened because of pytest-asyncio>=0.15.0 which changed in the past 9 months (50a9d85)
  • I replaced the mnist-text dataset that was used in the test_hf_shards.py file because it used dataset scripts which are no longer supported RuntimeError: Dataset scripts are no longer supported. Replaced with rotten_tomatoes because it uses parquet by default. (4d5b835)

Test plan

Got the CI running again.

@cirquit cirquit requested a review from artemru October 14, 2025 14:59
@cirquit cirquit self-assigned this Oct 14, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2025
@cirquit cirquit force-pushed the cirquit/fs2v0.6-uplevel branch from 3d619e7 to 7c04d3b Compare October 14, 2025 18:29
@cirquit cirquit force-pushed the cirquit/fs2v0.6-uplevel branch from 7c04d3b to 4d5b835 Compare October 14, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants