[pull] main from containerd:main #307
Open
+20,883
−4,315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed PATH resolution by using explicit nerdctl binary path in systemd service files, eliminating 'nerdctl' not found errors - Added default values for unspecified healthcheck flags to prevent silent failures Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
healthcheck: fix path issues and add default config values
Those tests should be enabled again once the flakiness is improved. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
CI: skip flaky tests on EL8 and ARM64
Bumps tonistiigi/xx from 1.7.0 to 1.8.0. --- updated-dependencies: - dependency-name: tonistiigi/xx dependency-version: 1.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/klauspost/compress/releases) - [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml) - [Commits](klauspost/compress@v1.18.0...v1.18.1) --- updated-dependencies: - dependency-name: github.com/klauspost/compress dependency-version: 1.18.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: clarehkli <clarehkli@tencent.com>
…otter add support for the newly added image conversion --estargz-gzip-helper option in stargz-snapshotter Signed-off-by: clarehkli <clarehkli@tencent.com>
See issue 4470 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
…/xx-1.8.0 build(deps): bump tonistiigi/xx from 1.7.0 to 1.8.0
add support for the new --estargz-gzip-helper option in stargz-snapshotter
….com/klauspost/compress-1.18.1 build(deps): bump github.com/klauspost/compress from 1.18.0 to 1.18.1
CI: mark TestPush flaky
- Create checkpoints from running containers using containerd APIs - Support both leave-running and exit modes via --leave-running flag - Configurable checkpoint directory via --checkpoint-dir flag Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
add unit tests for checkpoint create command. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
add checkpoint create command reference. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
add checkpoint restore support to container start. e.g.: $ nerdctl run --name cr -d busybox sleep infinity $ nerdctl checkpoint create cr checkpoint1 $ nerdctl start --checkpoint checkpoint cr Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
add unit test for container start with checkpoint. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
add nerdctl start with checkpoint command reference. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
install criu in ci to test checkpoint. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
introduce taskoptions to reduce argument numbers.
Otherwise, ci would be failed by:
```
Error: pkg/taskutil/taskutil.go:51:1: argument-limit:
maximum number of arguments per function exceeded; max 12 but got 13
func NewTask(ctx context.Context, client *containerd.Client,
container containerd.Container, attachStreamOpt []string,
isInteractive, isTerminal, isDetach bool, con console.Console,
logURI, detachKeys, namespace string, detachC chan<- struct{}, checkpointDir string)
```
Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
Write com.docker.compose.config-hash label on create/run. Fixes: #4547 Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
- TestComposeCreateWritesConfigHashLabel: verify config-hash label is written - TestComposeUpNoRecreateDependencies: ensure dependencies aren't recreated Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
compose: align convergence with Docker Compose
Currently, nerdctl CI uses docker 28.0.4, while docker version 28.x has a known regression that breaks Checkpoint/Restore functionality. The issue is tracked in the moby/moby project as moby/moby#50750. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
The nerdctl-full tarball was incorrectly creating symlinks for all files in libexec/cni/, including documentation files like README.md and LICENSE. This resulted in non-executable files appearing in bin/ as buildkit-cni-README.md and buildkit-cni-LICENSE. Add executable and regular file checks to the symlink creation loop to filter out non-executable files. The fix uses [ -x "$f" ] to check for execute permission and [ -f "$f" ] to ensure it's a regular file, so only actual CNI plugin binaries are symlinked. Tested: bin/ file count reduced from 46 to 44 files (removed 2 doc symlinks). All 18 CNI plugin executables still correctly symlinked. Fixes #4553 Signed-off-by: Sadique Azmi <sadiquemobaraka5@gmail.com>
fix: filter non-executable files when symlinking buildkit-cni plugins (#4553)
Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
checkpoint: support checkpoint create command
support nerdctl search
…est.go test: refactor compose_down_linux_test.go to use Tigron
…st-tigron Refactor/container start test tigron
CI: lint: increase timeout
…est.go test: refactor compose_kill_linux_test.go to use Tigron
Bumps the golang-x group with 1 update: [golang.org/x/sys](https://github.com/golang/sys). Updates `golang.org/x/sys` from 0.39.0 to 0.40.0 - [Commits](golang/sys@v0.39.0...v0.40.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-version: 0.40.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x ... Signed-off-by: dependabot[bot] <support@github.com>
fix: allow localhost DNS servers when using host network
…-x-e2678a00b5 build(deps): bump golang.org/x/sys from 0.39.0 to 0.40.0 in the golang-x group
Bumps the golang-x group with 2 updates: [golang.org/x/term](https://github.com/golang/term) and [golang.org/x/text](https://github.com/golang/text). Updates `golang.org/x/term` from 0.38.0 to 0.39.0 - [Commits](golang/term@v0.38.0...v0.39.0) Updates `golang.org/x/text` from 0.32.0 to 0.33.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.32.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-version: 0.39.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/text dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the docker group with 1 update: [github.com/docker/cli](https://github.com/docker/cli). Updates `github.com/docker/cli` from 29.1.3+incompatible to 29.1.4+incompatible - [Commits](docker/cli@v29.1.3...v29.1.4) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-version: 29.1.4+incompatible dependency-type: direct:production update-type: version-update:semver-patch dependency-group: docker ... Signed-off-by: dependabot[bot] <support@github.com>
In the current implementation, specifying an invalid string for the --pull option of the nerdctl compose create command causes it to fall back to missing, allowing the image to be pulled as shown below. ``` $ sudo nerdctl compose create --pull foo WARN[0000] Ignoring: service svc0: pull_policy: "foo" INFO[0000] Ensuring image alpine ... INFO[0004] Creating container fix-compose-pull-policy-with-invalid-option-svc0-1 ``` On the other hand, docker compose returns the following error in a similar situation. ``` $ docker compose create --pull foo invalid --pull option "foo" ``` This commit fixes it to be compatible with docker compose. Signed-off-by: Hayato Kiwata <dev@haytok.jp>
…-6d54fcc478 build(deps): bump github.com/docker/cli from 29.1.3+incompatible to 29.1.4+incompatible in the docker group
…alid-option fix: return error for invalid --pull option in nerdctl compose create
…-x-a63f6d53e1 build(deps): bump the golang-x group with 2 updates
Signed-off-by: Hayato Kiwata <dev@haytok.jp>
docs/command-reference.md: fix anchors without blue_square
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.1.0 to 6.2.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@4dc6199...7a3fe6c) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/go-viper/mapstructure/releases) - [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md) - [Commits](go-viper/mapstructure@v2.4.0...v2.5.0) --- updated-dependencies: - dependency-name: github.com/go-viper/mapstructure/v2 dependency-version: 2.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Hajime Ogi <robertcal900@gmail.com>
Signed-off-by: Hayato Kiwata <dev@haytok.jp>
Bumps [github.com/containerd/accelerated-container-image](https://github.com/containerd/accelerated-container-image) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/containerd/accelerated-container-image/releases) - [Commits](containerd/accelerated-container-image@v1.3.0...v1.4.0) --- updated-dependencies: - dependency-name: github.com/containerd/accelerated-container-image dependency-version: 1.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
….com/go-viper/mapstructure/v2-2.5.0 build(deps): bump github.com/go-viper/mapstructure/v2 from 2.4.0 to 2.5.0
…tions/setup-go-6.2.0 build(deps): bump actions/setup-go from 6.1.0 to 6.2.0
….com/containerd/accelerated-container-image-1.4.0 build(deps): bump github.com/containerd/accelerated-container-image from 1.3.0 to 1.4.0
Bumps the golang-x group with 2 updates: [golang.org/x/crypto](https://github.com/golang/crypto) and [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/crypto` from 0.46.0 to 0.47.0 - [Commits](golang/crypto@v0.46.0...v0.47.0) Updates `golang.org/x/net` from 0.48.0 to 0.49.0 - [Commits](golang/net@v0.48.0...v0.49.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.47.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/net dependency-version: 0.49.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x ... Signed-off-by: dependabot[bot] <support@github.com>
…time_linux_test.go test: refactor container_run_runtime_linux_test.go to use Tigron
…test.go test: refactor compose_pause_linux_test.go to use Tigron
…-x-75fb07cb15 build(deps): bump the golang-x group with 2 updates
Bumps [github.com/containerd/accelerated-container-image](https://github.com/containerd/accelerated-container-image) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/containerd/accelerated-container-image/releases) - [Commits](containerd/accelerated-container-image@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: github.com/containerd/accelerated-container-image dependency-version: 1.4.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
….com/containerd/accelerated-container-image-1.4.1 build(deps): bump github.com/containerd/accelerated-container-image from 1.4.0 to 1.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )