-
Notifications
You must be signed in to change notification settings - Fork 214
feat: added pdf download #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pdf-freewrite-demo.mov |
|
fuck yessss. will run it tmmro + merge TY SO MUCH. |
|
hmm why do we need export to pdf functionality? |
quiint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
hey @parthmshah1302 everything worked really well for me. i made a few changes w/ my PRs on file name, and just button placement aesthetics. Plz check and lmk and ill merge ty so much!! |
|
also you seem like you know what you're doing wanna help me w the rest of these PRs 😂 claude coded all this so idk if im fit to approve prs lol claude more qualified than me |
|
yolo lets merge. shipping in release rn <3. check in 15m. also would love help w this if you can: |
yes sir - i would love to help more. taking a look, starting with #27. |

Enhancements to PDF Export Functionality:
freewrite/ContentView.swift: Added import statements forUniformTypeIdentifiersandPDFKit, and implemented a newexportEntryAsPDFfunction to allow exporting entries as PDFs. This includes creating a PDF from text, handling file names, and displaying a save dialog. [1] [2]freewrite/ContentView.swift: Added a new state variablehoveredExportIdand updated the UI to include an export button that appears on hover, alongside the existing trash icon. [1] [2]Notes
.scrollIndicators(.never)modifier elsewhere in the code, this manual manipulation wasn't necessary for the functionality. The PDF export feature now works correctly with proper multi-page support, and the app's interface behavior remains consistent without these lines of code.defaultLineHeight()in favor of using the sharedgetLineHeight()function. This improves text layout consistency between screen display and PDF export while simplifying the codebase.