fix(rpm): remove system modification command from %install section#311
Open
eximius313 wants to merge 1 commit intofastforgedev:mainfrom
Open
fix(rpm): remove system modification command from %install section#311eximius313 wants to merge 1 commit intofastforgedev:mainfrom
eximius313 wants to merge 1 commit intofastforgedev:mainfrom
Conversation
The `update-mime-database` command was being executed in the `%install` section. This caused "Permission denied" errors during the build process because it attempted to modify the host system's `/usr/share/mime` directory instead of the buildroot. This command belongs in `%post` and `%postun` (which are already handled), not in `%install`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #308
The
update-mime-databasecommand was being executed in the%installsection. This caused "Permission denied" errors during the build process because itattempted to modify the host system's
/usr/share/mimedirectory instead of the buildroot.This command belongs in
%postand%postun(which are already handled in #307), not in%install.