Skip to content

Conversation

@marco66colombo
Copy link
Contributor

@marco66colombo marco66colombo commented Dec 15, 2025

Description

  • Move CI to new testing image 0.6.3.base (Py3.12, Keras3) and keep the default pytest jobs on the Keras2 env.
  • Update generate_ci_yaml.py so that Keras3-only tests run in a separate Keras3 job. Other tests stay batched on Keras2 env. Keras3-only set for: test_keras_v3_api.py, test_hgq2_mha.py, test_einsum_dense.py, test_qeinsum.py.
  • Keras3 coverage is split out because many legacy tests still hit Keras3 API changes; hgq2 MHA remains incompatible with Keras3 (parallelization_factor kwarg).

Note: pinned pytest<9 in testing extras to avoid pytest 9 hard error on marks applied to fixtures (existing tests still use that pattern).

Future work: decide which tests to port to Keras3 vs. keep on Keras2 vs. run on both, and track hgq2/Keras3 compatibility for MHA.

Type of change

  • CI/config change
  • Bug fix
  • Documentation update
  • New feature
  • Breaking change
  • Other

Tests

  • CI: will run split Keras2/Keras3 jobs; no local test run.

Checklist

  • I have read the contributing guidelines.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@marco66colombo marco66colombo changed the title fix precommit changes Add keras3 environment in tests Dec 15, 2025
@marco66colombo
Copy link
Contributor Author

  • Moved test_multiout_onnx into the Keras3 env/jobs because it was failing in the old (TF 2.14) env due to onnx/onnxscript/onnx-ir dependency conflicts. The newer env has compatible versions.

  • Temporarily skipped test_hgq2_mha since the current hgq2 release rejects the parallelization_factor kwarg that hls4ml passes.

@marco66colombo marco66colombo marked this pull request as ready for review December 18, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants