Make all methods take "coordinates" as input #233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our methods for doing computations like coordinate conversions and normal gravity calculations all take a different set of inputs. For example, normal gravity takes geodetic latitude and height which coordinate conversions also take longitude (though its not used). The spherical versions are more inconsistent since they sometimes take a height and sometimes not. Here, we standardize all of these methods to take a
coordinatesargument that is a tuple of the three coordinates longitude, latitude, and height. These are standard throughout other Fatiando a Terra projects. It also means that all of these methods take the same input. For methods that don't use longitude, etc, they can be passedNoneis desired. This will also make implementing an argument to specify inputs in different coordinate systems more straightforward since we won't have to deal with differences between latitudes and whether we're using height or radius.To do:
SphereTriaxialEllipsoidRelevant issues/PRs: Related to #175 #232