Skip to content

WIP Ledger Integration #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fboucquez wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

WIP Ledger Integration #263

fboucquez wants to merge 2 commits into from

Conversation

@fboucquez
Copy link
Owner

@fboucquez fboucquez commented Jun 7, 2021

No description provided.

segfaultxavi
segfaultxavi suggested changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@segfaultxavi segfaultxavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember that you should always read everything before submitting :D

rg911
rg911 reviewed Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@rg911 rg911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fboucquez what's the rationale behind supporting ledger in bootstrap? Would it be better to create a separate tool for it?

@fboucquez
Copy link
Owner Author

fboucquez commented Jun 7, 2021

@fboucquez what's the rationale behind supporting ledger in bootstrap? Would it be better to create a separate tool for it?

Bootstrap announces link and transfer transactions. This pr will let node admins sign those transactions with Ledger.

When the main account is wealthy enough, it's highly recommended to convert it to a multisig (at least 1-1) where one of the cosigners is a Ledger.

I'm going to push a small typescript ledger client library that allows other CLIs (or wallets) to connect to ledger more easily. This would the first cli tool to accept ledger

@fboucquez fboucquez force-pushed the ledger_integration branch 3 times, most recently from 1e4559f to 186e064 Compare June 7, 2021 21:10
@fboucquez fboucquez force-pushed the ledger_integration branch from 186e064 to d427a41 Compare June 7, 2021 21:57
@fboucquez fboucquez force-pushed the dev branch 11 times, most recently from 9627f1a to 347034c Compare January 14, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rg911 rg911 rg911 left review comments

+1 more reviewer

@segfaultxavi segfaultxavi segfaultxavi requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fboucquez @rg911 @segfaultxavi