Beam release and other modifications#56
Merged
Conversation
InesChampagne
commented
Nov 26, 2025
InesChampagne
commented
- in units, "tonne" instead of "ton" which is the American definition and not the one according to the SI
- BeamRelease Field implementation
- debug from_compas_lines -> orientation and no frame anymore + the prt.points needs to be initialized first
- result field updates as mentionned in meeting
- ciupling constraint implementation
- Debug of combination ( GravityField is special)
franaudo
reviewed
Nov 26, 2025
Collaborator
franaudo
left a comment
franaudo
left a comment
There was a problem hiding this comment.
all good: check fields combinations (Gravity) and fields name
franaudo
approved these changes
Nov 26, 2025
franaudo
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.