wizard: fix incorrect variable usage in key image export#276
Open
Oblivionsage wants to merge 1 commit intofeather-wallet:masterfrom
Open
wizard: fix incorrect variable usage in key image export#276Oblivionsage wants to merge 1 commit intofeather-wallet:masterfrom
Oblivionsage wants to merge 1 commit intofeather-wallet:masterfrom
Conversation
In PageOTS_ExportKeyImages.cpp, the setupUR() function was exporting key images to a local variable 'ki_export' but then passing the uninitialized 'm_wizardFields->keyImages' to setData(). This resulted in the UR widget displaying empty data. Changed to export directly to m_wizardFields->keyImages, matching the pattern used in PageOTS_ExportOutputs.cpp::setupUR(). This also ensures the data is properly available when exportKeyImages() writes to file. Fixes TODO at PageOTS_ExportKeyImages.cpp:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PageOTS_ExportKeyImages.cpp, the
setupUR()function was exporting key images to a local variableki_exportbut then passing the uninitializedm_wizardFields->keyImagestosetData(). This resulted in the UR widget displaying empty data.Changed to export directly to
m_wizardFields->keyImages, matching the pattern used inPageOTS_ExportOutputs::setupUR(). This also ensures the data is properly available whenexportKeyImages()writes to file.Fixes TODO at PageOTS_ExportKeyImages.cpp:56