-
Notifications
You must be signed in to change notification settings - Fork 43
Move from jQuery.click #6750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from jQuery.click #6750
Conversation
johnnyporkchops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6750 +/- ##
========================================
Coverage 79.79% 79.79%
========================================
Files 238 238
Lines 5247 5247
========================================
Hits 4187 4187
Misses 1060 1060 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Resolving the jQuery deprecations has been a burden so let's break #6411 into much smaller pieces
Required reviewers
Impacted areas of the application
General components of the application that this PR will affect:
click()and.click(𝑓)on/inScreenshots
No changes
Related PRs
Related PRs against other branches:
.click.change.focus,.blur.bind,:first,.hover,.keyCode,:last,.submit,.trim‡you are here
How to test
npm inpm run test-singleshould be clearnpm run build./manage.py runserverclickactions and handlers:feedback boxlink handler should open the feedback boxfeedback boxlink handler should open the feedback boxTabbing to individual events, return/enter should open the pop-upKNOWN ISSUE: doesn't work here or on Production.is-checkedand initially clicking/checking items isn't calling that function at all (i.e. clicking a new item works fine buthandleDropdownItemClick()isn't called