Avoid setting the default runner #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the default runner to tox's default when `--current-env` is not used can override another plugin like `tox-uv` which wants to change the default runner. According to [this comment](fedora-python#42 (comment)) the issue that led to the need to set the default runner has been addressed and that appears to be confirmed by testing.
Contributor
Author
|
I am not sure about the test failures but they seem unrelated to the changes here (problem setting up Python 3.7). |
Member
|
Do you mind if I add commits related to the CI problem to your PR? |
Contributor
Author
|
Fine with me 🙂 |
Member
|
Thank you. Working on a followup release in #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the default runner to tox's default when
--current-envis not used can override another plugin liketox-uvwhich wants to change the default runner. According to this comment the issue that led to the need to set the default runner has been addressed and that appears to be confirmed by testing.