Added server_port (server_ip:server_port) to cmdline args of dev server. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fergalwalsh
requested changes
Apr 1, 2020
Owner
fergalwalsh
left a comment
fergalwalsh
left a comment
There was a problem hiding this comment.
Thanks for this. See the minor comments.
pico/server.py
Outdated
Comment on lines
50
to
56
| except ValueError: | ||
| try: | ||
| server_port = socket.getservbyname(server_port, 'tcp') | ||
|
|
||
| # OSError in python3, but error in python2.7. | ||
| except Exception: | ||
| server_port = DEF_SERVER_PORT |
Owner
There was a problem hiding this comment.
I don't think we need to handle named ports. It seems like quite an uncommon use case.
If we get a ValueError we should raise a TypeError to inform the user that the port part of the string was not a valid port. e.g.:
raise TypeError('Invalid port number specified.')
pico/server.py
Outdated
| from werkzeug.middleware.shared_data import SharedDataMiddleware | ||
| from werkzeug.utils import import_string | ||
|
|
||
| DEF_SERVER_IP = '127.0.0.1' |
Owner
There was a problem hiding this comment.
+1 for using constants for these but please let's use DEFAULT_SERVER_IP & DEFAULT_SERVER_PORT. Or maybe simply DEFAULT_IP & DEFAULT_PORT?
Contributor
Author
There was a problem hiding this comment.
Hi Fergal, Added a new commit with the changes you requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Fergal, I added dev server port on cmdline as you asked.