Open
Conversation
Closed
Collaborator
|
I believe I see the point of this PR but somehow it feels wrong to duplicate all that code into a separate method. Especially with no documentation and tests around it. And most likely what this method really adds can be achieved with: // I've not actually tested this code!!!
import retrace from 'retrace';
let {source, line, column} = require('error-stack-parser').parse({stack: stack}).map(retrace.mapFrame, retrace)[0];
// There is a Promise.all in the original code but I can't see anything Promis-ified in the error-stack-parser's code ....But anyway @fgnass would be best to advise if this could/should be merged. As for the tests, I've been trying lately to revive the test suite so there is something to keep the library from regressing when changes are being made but I've not been able to fully run those yet. It turned to be quite a challenge to get those to run on the SauceLabs runner. Cheers |
Author
|
@gkostov I agree with you. I'll try to avoid duplicating the code and add a test code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are often cases where not only the 'stack' but also the 'column,' 'line,' and 'source' information are needed.
This function returns both the 'stack' and the additional 'source,' 'column,' and 'line' information of the last call stack.