Skip to content

feat: add getStackInfo function#20

Open
hajeonghun wants to merge 1 commit intofgnass:masterfrom
hajeonghun:master
Open

feat: add getStackInfo function#20
hajeonghun wants to merge 1 commit intofgnass:masterfrom
hajeonghun:master

Conversation

@hajeonghun
Copy link

There are often cases where not only the 'stack' but also the 'column,' 'line,' and 'source' information are needed.

This function returns both the 'stack' and the additional 'source,' 'column,' and 'line' information of the last call stack.

@hajeonghun hajeonghun mentioned this pull request Jul 25, 2023
@gkostov
Copy link
Collaborator

gkostov commented Jul 28, 2023

I believe I see the point of this PR but somehow it feels wrong to duplicate all that code into a separate method. Especially with no documentation and tests around it. And most likely what this method really adds can be achieved with:

// I've not actually tested this code!!!
import retrace from 'retrace';
let {source, line, column} = require('error-stack-parser').parse({stack: stack}).map(retrace.mapFrame, retrace)[0];
// There is a Promise.all in the original code but I can't see anything Promis-ified in the error-stack-parser's code ....

But anyway @fgnass would be best to advise if this could/should be merged.

As for the tests, I've been trying lately to revive the test suite so there is something to keep the library from regressing when changes are being made but I've not been able to fully run those yet. It turned to be quite a challenge to get those to run on the SauceLabs runner.

Cheers

@hajeonghun
Copy link
Author

@gkostov I agree with you. I'll try to avoid duplicating the code and add a test code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants