add name_eng materials added in Avalon le Fae #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
これは Game Data APIを使って実装されたときにfgoscdataのupdate.pyによって自動的に英語名が入る機能で補完されますので、この差分を適用しても、update.pyの実行によって上書きされてしまいます 英語名対応は、Atlas Achademyで英語版FGOのスクリーンショットを処理するためにいれたもので、日本語版FGOのデータを処理したら未実装の英語名が対応していないのは仕様です ――という事情を説明した上で質問となるのですが、日本語版のデータを英語で使いたいと思ってます? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--lang engオプションで鱗粉・小鐘が日本語のままになっていたため、アヴァロン・ル・フェで追加された素材のname_engを追加をしました。
before
after
name_engは こちら から拝借しました。