[TASK] V11 compatibility #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Readme file needs to be adjusted as well. The command "ddev install-full" is not available anymore. |
PKuhlmay
reviewed
May 29, 2024
This was referenced May 29, 2024
Riiiad
force-pushed
the
update-11-lts
branch
7 times, most recently
from
e139ccc to
525fc3d
Compare
PKuhlmay
reviewed
Oct 7, 2024
With rebuilding and refactoring, two dependencies were added in `composer.json`. In addition to this, the respective dependencies were added in `ext_emconf.php` ensuriung correct behaviour on legacy installations.
TypoScriuptt Linter issued code smells, which were fixed. In addition, the `.editorconfig` is adopted matching the linter requirements
Removed superfluous code and installed TYPO3/testingFramework Used commands: ```shell composer remove --dev ergebnis/composer-normalize composer remove --dev ssch/typo3-rector composer require --dev typo3/testing-framework:^7.1 ```
In addition to the introduction ofthe TYPO3 testing framework, adopt the configurations matching phpunit 10.5.
With the goal of getting the Extension working with TYPO3 11 and above and dropping the support for older TYPO3 versions, remove classes taking care of older versions, as they are no longer needed
The Update wizards are no longer used and could be removed. As there is the possibility, someone wants to upgrade from versions below 0.9, deprecate the classes and mark them to be removed in a later version
In efforts to a better code maintainability, add small tests for some parts, testing the functionality of the testing infrastructure and allow the pipelines run the tests.
calien666
force-pushed
the
update-11-lts
branch
2 times, most recently
from
0974ebf to
584e1b6
Compare
According to old TypoScript extbase configuration, add the class names as array-keys for usage in TCA. This allows updating without any breaking inside the database models, as the models itself are registered with their respective class names as `recordType`.
Within v11 it is recommended to use `ResponseInterface` returns. During the refactoring, most was done, but it was overseen, that the created responses are used.
Add event changeable properties and streamline the response.
The old slot-adapted solution had a high potential for attacking itself and thus getting stuck in an event caller loop. The modification made here places the event handling on the PollController and allows for finer adjustment, as each step is now stored individually as an event. On the one hand, this facilitates troubleshooting and, on the other hand, prevents an unintentional event-in-event loop, which was previously the case. At the same time, exception handling is optimised and case-specific exceptions are thrown, which clearly identify the permissions as the source of the error and which permission is actually missing at that point. The controller itself has been modified so that all actions now return a ResponseInterface, which will suffice for a later upgrade to TYPO3 v12.
As the ViewHelper used deprecated `CompileWithRenderStatic`, refactor to `AbstractConditionViewHelper` and rework the respective templates.
Before refactoring to EventListeners, the Slots could create redirects after manipulating the data. This technique could be used again, but for getting a clearer state, it is better to use response manipulation through the event and the respective Listeners ensuring the response being returned directly inside the controller instead of some other places. Create the default redirect response as variable inside the controller action and override with the manipulated one from the event. This ensures a clean state and proper possibilities for the manipulation
In favour of an early check and exit, add an event to the newAction, which allows a check for event listeners and an earlier return and exception throwing than on create action.
sbuerk
approved these changes
Aug 22, 2025
Contributor
|
@calien666 Let's coordinate on merging & tagging / releasing. Currently we do not have the TER access to upload a ter release anyway, pinged @a-r-m-i-n in slack to transfer the key to web-vision for that. |
Contributor
|
@sbuerk I'm on vacation right now. Checking Slack next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for TYPO3 version 11.
Fixes #5