122. Best Time to Buy and Sell Stock II #39
+74
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shining-ai
reviewed
Jul 9, 2024
Comment on lines
+66
to
+67
| if not prices: | ||
| return 0 |
There was a problem hiding this comment.
priceが空でもfor文に入らず初期値の0が返るので不要かと思いました。
priceが空のときの例外処理を想定しての記載でしたら問題ないです。
hayashi-ay
reviewed
Jul 9, 2024
| return 0 | ||
| max_profit = 0 | ||
| for i in range(1, len(prices)): | ||
| difference = prices[i] - prices[i - 1] |
There was a problem hiding this comment.
確かにdifferenceではあるんですけど、profit, gainなどの方がよりこの値の指している意味が伝わるかなと思います。
Owner
Author
There was a problem hiding this comment.
差額が0より大きければprofitに加算する、と考えて書いてみたんですが、微妙ですかね？
pay the difference 的なイメージです。
(prices[i] - prices[i - 1]が負になることもあるので差額の方が自分的にしっくり来た)
There was a problem hiding this comment.
自分英語の細かいニュアンスまでは分からなくて、とはいえdifferenceでも良いとは思います。
differenceだと値の向きが変数だけだと分からないかなというのが個人的な感覚でした。differenceがプラスの場合にprofit or lossのどちらを意味するのかというのが分からず、それだったらprofitと命名してあげる方が理解がすぐできるかなと思いました。個人的にはprofitがマイナスになっても特段違和感がないです。
nodchip
reviewed
Jul 9, 2024
| - 空間計算量: O(1) | ||
|
|
||
| ```py | ||
| class Solution: |
There was a problem hiding this comment.
自分は 2nd の解法で解いたのですが、 1st の解法のほうがシンプルで良いと思いました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/best-time-to-buy-and-sell-stock-ii/description/