Skip to content

Conversation

@keiranjprice101
Copy link
Collaborator

Closes #

Description

…pdates into a single deploy job, triggered only on main branch pushes.
…ehensive project README, and a root `pyproject.toml` for shared configuration.
…sk timeout assertion, and introduce linting exclusions.
Copy link
Member

@Pasarus Pasarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add some unit tests notably the only thing I have noticed worth it, is likely that function I asked to go into a Util file.

I am guessing the reason we have a pyproject.toml at the root of the repo is for the e2e tests only? and the e2e needs both components in order to be worthwhile, is that correct?

@keiranjprice101
Copy link
Collaborator Author

keiranjprice101 commented Feb 2, 2026

@Pasarus

I am guessing the reason we have a pyproject.toml at the root of the repo is for the e2e tests only? and the e2e needs both components in order to be worthwhile, is that correct?

This was actually to allow ruff to run on both services at the same time in CI

steps:
- uses: actions/checkout@v3

- name: Build and Run Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably also want to test the unit tests here right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added unit test jobs for both llsp worker and llsp api. The worker currently just contains a placeholder test as the functionality is not yet specialised enough to be tested. But this will ensure this same miss doesn't happen again in the future.

@Pasarus Pasarus merged commit 5bd50d9 into main Feb 2, 2026
4 checks passed
@Pasarus Pasarus deleted the initial_setup branch February 2, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants