Bump @h5web/app to ^15.0.0 #307
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the data-viewer Next.js app to target H5Web v15.
Changes:
- Bumped
@h5web/appdependency indata-viewer/package.jsonto^15.0.0. - Added a root
yarn.lockfile (currently empty/truncated). - Added
node_modules/.yarn-integrity(install artifact).
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
data-viewer/package.json |
Updates the declared H5Web version range to v15. |
yarn.lock |
Introduces a root lockfile, but it contains only the header (no entries). |
node_modules/.yarn-integrity |
Adds a machine-specific Yarn install artifact under node_modules/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "systemParams": "win32-x64-115", | ||
| "modulesFolders": [], | ||
| "flags": [], | ||
| "linkedModules": [], | ||
| "topLevelPatterns": [], | ||
| "lockfileEntries": {}, | ||
| "files": [], | ||
| "artifacts": {} |
There was a problem hiding this comment.
node_modules/.yarn-integrity is a machine-specific install artifact (note the systemParams: win32-x64-115) and should not be committed. Please delete this file from the PR and ensure node_modules/ at the repo root is ignored by git (the current */node_modules pattern does not ignore a top-level node_modules).
| "systemParams": "win32-x64-115", | |
| "modulesFolders": [], | |
| "flags": [], | |
| "linkedModules": [], | |
| "topLevelPatterns": [], | |
| "lockfileEntries": {}, | |
| "files": [], | |
| "artifacts": {} |
| "dependencies": { | ||
| "@emotion/react": "11.13.3", | ||
| "@emotion/styled": "11.13.0", | ||
| "@h5web/app": "^12.0.1", | ||
| "@h5web/app": "^15.0.0", | ||
| "@mui/material": "6.1.4", |
There was a problem hiding this comment.
data-viewer/yarn.lock still pins @h5web/app to 12.0.1 (entry "@h5web/app@^12.0.1"), so bumping the version range here will not actually update the installed version for reproducible installs. Please run yarn install (or the repo’s standard upgrade workflow) in data-viewer/ to update data-viewer/yarn.lock to v15 and include that lockfile change in the PR.
Closes #291.
Description
Starts using h5web 15.