feat: EC2 2023 8.5-Strut and Ties#124
feat: EC2 2023 8.5-Strut and Ties#124DanielGMorenaFhecor wants to merge 34 commits intofib-international:dev-ec2-2023from
Conversation
Co-authored-by: talledodiego <38036285+talledodiego@users.noreply.github.com>
…codes into ec_2004_crack_control
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
Excellent contribution and code @DanielGMorenaFhecor. For me some minor adjustments and is ready for merge.
|
|
||
| theta_rad = math.radians(theta_cs) | ||
| cot_theta = 1 / math.tan(theta_rad) | ||
| return 1 / (1.11 + 0.22 * (cot_theta**2)) |
There was a problem hiding this comment.
Are we sure that using eq. 8.119 we have the same limits for theta as using eqs. 8.115-8.118?
There was a problem hiding this comment.
That is a good question! Mmm... If i perform the calculations in a simple Excel Worksheet I am getting the following values:
| Angle | Rads | Cotg | Nu |
|---|---|---|---|
| 20 | 0.349 | 2.747 | 0.36 |
| 30 | 0.524 | 1.732 | 0.56 |
| 40 | 0.698 | 1.192 | 0.70 |
| 60 | 1.047 | 0.577 | 0.85 |
| 90 | 1.571 | 0.000 | 0.90 |
Values from 8.199 are more or less similar to values from Eq. 8.115-8.118, but limits are not identical.
Would you suggets implementing both approaches in the codebase?
There was a problem hiding this comment.
Thanks for the comment. I agree with your observation, I see equations 8.115-8.118 as alternative formulation to 8.119.
We can either implement the two approaches or leave only the 8.119 approach. Either way, I am not sure that equation 8.119 is not valid for an angle lower than 20 degrees.
tests/test_ec2_2023/test_ec2_2023_section_8_5_struct_and_ties.py
Outdated
Show resolved
Hide resolved
tests/test_ec2_2023/test_ec2_2023_section_8_5_struct_and_ties.py
Outdated
Show resolved
Hide resolved
tests/test_ec2_2023/test_ec2_2023_section_8_5_struct_and_ties.py
Outdated
Show resolved
Hide resolved
|
Thank you very much Diego for your comments! I already fixed the typos. I have just one question regarding the use of the equations 8.115-8.118 and 8.119. Please, refer to the comment for further explanation. 👍 |
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
I agree with your comment. The only thing, I am not sure that theta must be between 20 and 90 when using 8.119. For how it is written the code I think the equation is valid also for angles lower than 20° maybe?
Anyhow excellent, in my opinion it can be merged in dev!
|
I have been considering equation 8.119 and its implications. It seems logical to allow for values lower than 20°, especially when trying to establish an analogous relationship with equation 8.121: To achieve this, I have adapted the method for computing ν as a function of the angle theta, allowing values between 0° and 90°. An important modification includes incorporating a small epsilon to handle cases where |
mortenengen
left a comment
mortenengen
left a comment
There was a problem hiding this comment.
Excellent contribution @DanielGMorenaFhecor. I have merged dev, added a couple of changes to the docstrings, and added the functions to the API docs. Could you please add tests that cover the lines that are not yet covered in _section_8_5_strut_and_ties.py?
3 participants
This PR implements the different formulas under the Chapter 8.5-Strut and Ties from the EC2-2023.
Related issues: #57 , #58 and #59.