feat: EC2 2023 6-Durability#126
Open
DanielGMorenaFhecor wants to merge 32 commits intofib-international:dev-ec2-2023from
Open
feat: EC2 2023 6-Durability#126DanielGMorenaFhecor wants to merge 32 commits intofib-international:dev-ec2-2023from
DanielGMorenaFhecor wants to merge 32 commits intofib-international:dev-ec2-2023from
Conversation
Co-authored-by: talledodiego <38036285+talledodiego@users.noreply.github.com>
…codes into ec_2004_crack_control
1 task
talledodiego
requested changes
Aug 6, 2024
Collaborator
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
Perfect contribution! Thanks @DanielGMorenaFhecor. Just minor comments that you can feel free to accept or neglect and some minor fixes before merging.
Collaborator
Author
|
Diego, I really appreciate your time in reviewing this Chapter! I have made the modifications and improvements in the methods and tests so I already think that we can merge this with the |
mortenengen
requested changes
Oct 11, 2024
Member
mortenengen
left a comment
mortenengen
left a comment
There was a problem hiding this comment.
Thanks for the great contribution 😃
I have merged dev and fixed docstrings.
There are still some lines that are not covered by tests. Please add tests so that we reach 100% coverage for the added code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for the Chapter-6 Durability from the new Eurocode 2:2023