feat: MC2020 14.6.1-Material properties of concrete#155
feat: MC2020 14.6.1-Material properties of concrete#155DanielGMorenaFhecor wants to merge 36 commits intofib-international:devfrom
Conversation
Co-authored-by: talledodiego <38036285+talledodiego@users.noreply.github.com>
…codes into ec_2004_crack_control
DanielGMorenaFhecor
added
enhancement
| return 0.20 | ||
|
|
||
|
|
||
| def sigma_c( |
There was a problem hiding this comment.
This function should be considered removed in favour of one of our builtin constitutive laws. @talledodiego can you advice on this?
|
|
||
| # Dictionary for normal concrete grades and | ||
| # their respective fck and fck,cube values | ||
| _concrete_strengths = { |
There was a problem hiding this comment.
I think this is a clever solution when the data is given in a table in the code, but it might be a short-coming when we start implementing methods on the material level, and the characteristic cylinder strength is the expected input and not the strength class. @talledodiego any thoughts on this?
|
|
||
|
|
||
| # Dictionary for concrete properties based on grade | ||
| concrete_properties = { |
mortenengen
left a comment
mortenengen
left a comment
There was a problem hiding this comment.
What a massive PR @DanielGMorenaFhecor! Thanks for the contribution 💪
I have merged dev, fixed docstrings, added the functions to the API docs, left a couple of comments, and asked @talledodiego for a review of compliance with the design code.
| @@ -0,0 +1,1363 @@ | |||
| """Tests for fib MC2020 Chapter 14.6.1.""" | |||
There was a problem hiding this comment.
There are several lines that are not covered by tests. Can you please add tests to reach 100% coverage of the contribution?
2 participants
Please, find here all the code implementations for the following specified chapters:
The code is already up to review 👍