refactor: use point.buffer to create circular polygon#314
refactor: use point.buffer to create circular polygon#314andrefmello91 wants to merge 5 commits intofib-international:devfrom
Conversation
|
Thanks for this improvement @andrefmello91! I have left one comment for you to consider while finalizing 😃 |
|
Thanks for this @mortenengen! |
|
Thanks for the fix, @andrefmello91. I noticed now that the PR was setup to merge with main instead of dev, and therefore our pipeline with code format, linting and testing was not triggered. A local run of the pipeline shows that all is good except for one test of a large circular section. I will unfortunately not have time to look into this before the coming week, but please feel free to explore the issue further and propose a solution 😃 Please note that I have pushed a commit that formats the code and adds a note in the docstring of |
|
Sorry for making the PR in the main branch. |
No worries 😄 I will have a closer look the coming week. |
Use shapely default way for creating a circle.