docs: explain sign convention for moments#316
Merged
mortenengen merged 6 commits intodevfrom Feb 17, 2026
Merged
Conversation
mortenengen
reviewed
Feb 17, 2026
mortenengen
reviewed
Feb 17, 2026
mortenengen
reviewed
Feb 17, 2026
mortenengen
reviewed
Feb 17, 2026
Member
|
Thanks for this improvement! I have added a couple of comments for you to consider while finalizing. |
Collaborator
Author
|
Thanks for the review. I implemented the changes asked. |
Co-authored-by: Vetle Espeseth <vetle.espeseth@multiconsult.no>
mortenengen
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mortenengen as follow up of previous comments I crated this PR to better explain the sign convention for moments.
thetaand fixed the note that was wrong.PS: I used as base dev, I am not sure if I should have used docs?