Skip to content

Return http status code before deployTasks completes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuta0801 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return http status code before deployTasks completes #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a953a8a
Return http status code before deployTasks completes
yuta0801 Dec 21, 2017
98f7782
0.2.1
yuta0801 Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ getConfig(function (config) {

console.log('Valid payload! Running commands');

deployTasks.run(function () {
res.status(200).send();
});
res.status(200).send();

deployTasks.run();

} else {
// if other branches were updated, send 200 only to make github happy...
Expand Down
5 changes: 2 additions & 3 deletions lib/deployTasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ var async = require('async'),
}
}

deployTasks.run = function (cb) {
deployTasks.run = function () {
if (!initConfigCalled) {
throw new Error('You should call initConfig first');
}
Expand All @@ -45,8 +45,7 @@ var async = require('async'),
deployTasks.commandFactory(stopCmd),
deployTasks.commandFactory(updateCmd),
deployTasks.commandFactory(postUpdateCmd),
deployTasks.commandFactory(startCmd),
cb
deployTasks.commandFactory(startCmd)
]);
};
})();
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "github-webhooks-listener",
"version": "0.2.0",
"version": "0.2.1",
"description": "A module to listen to github hooks and to update and deploy project when push event occurs",
"main": "index.js",
"scripts": {
Expand Down