chore: update to 2.18 and add prediction_log.proto
#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
figroc
approved these changes
Jan 28, 2025
Owner
|
Thanks for your PR. I'll look into the failed CI in following couple days and merge it. |
cyanic-selkie
changed the title
Author
|
Sorry, it's potentially my bad as I made the proto glob too permissive. I've reverted it to the original glob and only added that single |
cyanic-selkie
changed the title
prediction_log.proto
|
Hey there @figroc! Any possibility you review this PR this week or early next week? This would be useful for my team as well. Thanks! |
Owner
There are 2 proto files missing in the PR. I'm looking into it. |
Owner
|
I'll merge this PR and patch the issues shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the
prediction_log.prototo be able to generate the TFRecord for the Tensorflow Serving Warmup feature. At the same time, it bumps the TF version to 2.18.