DDO with notifications spike#2026
Open
ZenGround0 wants to merge 2 commits intofilecoin-project:mainfrom
Open
Conversation
Contributor
Author
|
FYI this is currently failing with a problem in the esoteric polydawn cbor encoding library. Probably related to the type in question partially implementing cbg (un)marshal. Here is the error that Tippy hit when running in production: When we pick this up first order of business is to fix that and probably tweak the test / add a new test. To fix the above I would guess we want to create cbg methods on a type alias set to []DataActivationNotification FYI @warpfork your memory lives on and we miss you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a spike branch for enabling manual testing. Actual support for "DDO+" where smart contracts can receive notifications of sector prove commit will probably look similar. But this PR doesn't do any of the hard cleanup stuff like sql migrations or thinking through exactly what the best api breaking change is.