Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feat/http #227 +/- ##
=============================================
+ Coverage 70.66% 71.29% +0.62%
=============================================
Files 64 67 +3
Lines 5543 6072 +529
=============================================
+ Hits 3917 4329 +412
- Misses 1413 1500 +87
- Partials 213 243 +30
|
kylehuntsman
requested review from
hannahhoward and
rvagg
and removed request for
rvagg
rvagg
reviewed
May 11, 2023
rvagg
reviewed
May 11, 2023
rvagg
reviewed
May 11, 2023
rvagg
reviewed
May 11, 2023
rvagg
reviewed
May 11, 2023
rvagg
reviewed
May 11, 2023
rvagg
reviewed
May 11, 2023
rvagg
reviewed
May 11, 2023
Collaborator
hannahhoward
left a comment
hannahhoward
left a comment
There was a problem hiding this comment.
After fixing @rvagg 's notes about UnixFS setup (sorry, IPLD is weird), we should test pathing over HTTP too
Collaborator
hannahhoward
left a comment
hannahhoward
left a comment
There was a problem hiding this comment.
After fixing @rvagg 's notes about UnixFS setup (sorry, IPLD is weird), we should test pathing over HTTP too
Collaborator
|
but pathed tests can be in a seperate PR, lower priority. |
rvagg
reviewed
May 12, 2023
| } | ||
| } | ||
|
|
||
| func MockIpfsHandler(ctx context.Context, lsys linking.LinkSystem) func(http.ResponseWriter, *http.Request) { |
Member
There was a problem hiding this comment.
seems like this can be moved in to peerhttpserver.go now?
rvagg
approved these changes
May 12, 2023
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
lgtm, I would like to see path tests in there though, they look like they're supported on the server side so it should just mean copying the graphsync ones
hannahhoward
force-pushed
the
test/http-itests
branch
from
5331ef7 to
68fd2be
Compare
hannahhoward
added a commit
that referenced
this pull request
May 12, 2023
* First pass at adapting graphsync to http * fix(http): gracefully handle selector vs path requests * feat(http): extend graphsyncretriever so it can also do http * feat(http): refactor http & graphsync specific pieces to "TransportProtocol" iface * feat(prioritywaitqueue): add InitialPauseDone inspector * feat(http): single peer http retrieval unit test * fix(http): enable http everywhere gs & bs are * chore(http): framework for suite of http unit tests based on bitswap unit test framework * feat(http): remove parallel-request flow, make all serial for now * too-detailed http testing, will remove this in favour of graphsync style testing. * fix(http): better testing framework * fix(http): more test coverage, minor fixes * fix(http): clean up time handling in tests * HTTP CAR validation (#222) * feat(verifiedcar): initial verifiedcar package * feat(verifiedcar): verify http retrievals * chore(verifiedcar): tests for basic error cases * fix(verifiedcar): coverage of more cases, handle known edges properly * fix(verifiedcar): remove extraneous go-routine (#226) Co-authored-by: Rod Vagg <rod@vagg.org> * fix(verifiedcar): address feedback * fix(verifiedcar): fix flaky tests --------- Co-authored-by: Hannah Howard <hannah@hannahhoward.net> * fix(http): refactor MockRoundTripper (#229) * Add HTTP integegration tests (#227) * test: add itests for http * test: add peer http server, minor refactors and fixes * fix(itest): fix compile errors on rebase --------- Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: Hannah Howard <hannah@hannahhoward.net> Co-authored-by: Kyle Huntsman <3432646+kylehuntsman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds HTTP integration tests that test that Lassie can fetch a valid car over the HTTP protocol. Remote HTTP peers are generated with an http multiaddress and run an HTTP server on that address for serving valid cars.
Notable Changes
itest/testpeer/generator.gocan now generate HTTP peers with an HTTP server that returns valid carsitest/testpeer/mocknet.gohas been updated to add HTTP peersitest/testpeer/peerhttpserver.goto create separate http server instances for each peer, as well as manage start and teardown appropriately.