Skip to content

Conversation

@emberian
Copy link
Contributor

simple update of @brandonros original PR on top of #90 (for after that is merged)

Closes #75

@brandonros
Copy link

💪

@vmx
Copy link
Contributor

vmx commented Apr 2, 2025

I've merged the other PR, hence this one needs a rebase and some Clippy fixes.

@BigLep
Copy link
Member

BigLep commented May 30, 2025

@emberian : do you want to get this updated so CI passes?

@BigLep
Copy link
Member

BigLep commented Jul 1, 2025

@rvagg : is this worth getting over the line or just closing for now until this is more interest?

@rvagg
Copy link
Member

rvagg commented Jul 1, 2025

worth getting this over the line

@BigLep BigLep requested a review from Copilot July 1, 2025 14:20
@BigLep BigLep added this to FilOz Jul 1, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Jul 1, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends support for Apple Silicon while also refactoring error handling and streamlining unsafe block usage in both OpenCL and CUDA modules. Additionally, the version upgrades in the toolchain and dependencies ensure compatibility with recent releases.

  • Changed error wrapping in OpenCL and CUDA modules from tuple to struct-style.
  • Added Apple vendor identifiers and strings to support Apple Silicon.
  • Updated toolchain and dependency versions for improved language and library support.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/opencl/mod.rs Refactored error returns to use struct-style and streamlined unsafe block style
src/error.rs Updated GPUError::Opencl3 variant to a structured format
src/device.rs Added Apple vendor string and vendor ID along with new Vendor::Apple variant
src/cuda/utils.rs Added attribute to suppress unused warnings in CudaContexts
src/cuda/mod.rs Replaced map_err with inspect_err and streamlined unsafe block usage
rust-toolchain Bumped rust version from 1.70.0 to 1.81.0
Cargo.toml Upgraded dependency versions and updated rust-version to 1.81.0

emberian and others added 4 commits July 1, 2025 11:42
Apple Silicon GPUs are integrated into the SoC and don't use PCI bus.
This change ensures synthetic PCI-ID assignment for Apple devices.
@BigLep
Copy link
Member

BigLep commented Jul 1, 2025

worth getting this over the line

@rvagg : with Claude, I got this updated and passing. Ready for review.

@BigLep BigLep requested a review from rvagg July 1, 2025 18:54
@BigLep BigLep moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Jul 1, 2025
steps:
- uses: actions/checkout@v4
- name: Install clippy
run: rustup component add clippy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right way to do this is add them both to rust-toolchain.toml

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Jul 2, 2025
@rvagg rvagg merged commit 79c63a4 into filecoin-project:master Jul 2, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

5 participants