Skip to content

Conversation

@austgate
Copy link

GCC was failing to compile the C++ code with errors about a string namespace and an unsigned int. I've patched these add managed to recompile with the below make file. I have also included a patch file.

@filox
Copy link
Owner

filox commented Sep 13, 2013

This mostly depends on what version of the compiler and what flags you are
using. I didn't add a Makefile to the project for this exact reason.
Btw, I do agree with the std::string change, but changing int to unsigned
int is not the best practice (it can end very badly) and I want to keep
counters int.

On Fri, Sep 13, 2013 at 2:34 PM, Iain Emsley notifications@github.comwrote:

GCC was failing to compile the C++ code with errors about a string
namespace and an unsigned int. I've patched these add managed to recompile

with the below make file. I have also included a patch file.

You can merge this Pull Request by running

git pull https://github.com/austgate/StormCpp master

Or view, comment on, or merge it at:

#4
Commit Summary

  • Added namespace to stirng
  • Altered int to being unsigned
  • Patch file for compiler errors
  • Makefile for project

File Changes

Patch Links:

@austgate
Copy link
Author

Thanks for the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants