Minor updates to make the "read"-class version independent#94
Open
Kajwan wants to merge 9 commits intofineprint-global:data-2010-currentfrom
Open
Minor updates to make the "read"-class version independent#94Kajwan wants to merge 9 commits intofineprint-global:data-2010-currentfrom
Kajwan wants to merge 9 commits intofineprint-global:data-2010-currentfrom
Conversation
Collaborator
|
There are some conflicts. Please, those contributing to the python-import app try to resolve them. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified parts of the code and edited some documentation.
It should now run for both the original version and new version of FABIO, as well as the calorie version.
I am a bit unsure about the versioning, but I use "1.1" for the original version (years 1986-2013) and "1.2" for the new version (years 1986-2020). It also works for the calorie version of FABIO.
There is still room for improvement. It should be made independent of io_codes.csv and su_codes.csv files and instead produce that information based on items.csv, regions.csv, and information stored in the RDS files. In that way it will become more robust.