MongoDB collection name quoting/unquoting using Pure grammar utilities #4134
+68
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes MongoDB grammar parser to properly handle collection names with spaces and special characters by implementing standard Pure grammar utilities for identifier quoting and unquoting.
- Replace custom collection name handling with
PureGrammarComposerUtility.convertIdentifier()for automatic quoting during composition - Use
PureGrammarParserUtility.fromGrammarString()for proper unescaping of quoted collection names during parsing - Add round-trip test case to validate collection names with spaces work correctly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MongoDBSchemaComposer.java | Updated to use standard Pure grammar utility for identifier quoting |
| MongoDBSchemaParseTreeWalker.java | Updated to use standard Pure grammar utility for string unescaping |
| TestMongoDBGrammarRoundTrip.java | Added test case for collection names with spaces |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mateusz-klatt
force-pushed
the
mongo
branch
2 times, most recently
from
538f0e6 to
1eca0ac
Compare
mateusz-klatt
force-pushed
the
mongo
branch
3 times, most recently
from
bfb44b9 to
d860771
Compare
mateusz-klatt
force-pushed
the
mongo
branch
2 times, most recently
from
56b78bf to
94be07a
Compare
… utilities - Replace custom collection name handling with PureGrammarComposerUtility.convertIdentifier() for automatic quoting - Use PureGrammarParserUtility.fromGrammarString() for proper unescaping of quoted collection names - Add round-trip test for collection names with spaces - Ensures consistency with other Pure grammar modules for identifier handling Fixes finos#4133
mateusz-klatt
changed the title
mateusz-klatt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix MongoDB grammar parser to properly handle collection names with spaces and special characters by using standard Pure grammar utilities.
Changes
PureGrammarComposerUtility.convertIdentifier()for automatic quotingPureGrammarParserUtility.fromGrammarString()for proper unescaping of quoted collection namesWhat type of PR is this?
Bug Fix
What does this PR do / why is it needed ?
Previously, MongoDB collection names with spaces were not properly parsed - the quotes were not removed during parsing, causing collection names like
"Person With Spaces"to be stored with the quotes included instead of justPerson With Spaces.This fix ensures that:
Which issue(s) this PR fixes:
Fixes #4133
Other notes for reviewers:
The changes use existing Pure grammar utilities that are already used consistently across other modules in the Legend Engine codebase. All existing tests continue to pass, and a new test case validates the fix for collection names with spaces.
Does this PR introduce a user-facing change?
Yes - collection names with spaces and special characters will now be properly handled in MongoDB grammar files.
Test Results
All existing tests pass, including the new test case
testSingleCollectionMongoDBStoreGrammarWithSpaces()which validates proper handling of collection names with spaces.Files Changed
MongoDBGrammarComposer.java- Updated to usePureGrammarComposerUtility.convertIdentifier()MongoDBGrammarParser.java- Updated to usePureGrammarParserUtility.fromGrammarString()TestMongoDBGrammarRoundTrip.java- Added test case for collection names with spaces