-
Notifications
You must be signed in to change notification settings - Fork 4
Add comprehensive macOS support to snapx deployment tool #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
6
commits into
develop
Choose a base branch
from
copilot/fix-429
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: peters <869+peters@users.noreply.github.com>
Co-authored-by: peters <869+peters@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for macOS
Add comprehensive macOS support to snapx deployment tool
Sep 17, 2025
Copilot stopped work on behalf of
peters due to an error
September 17, 2025 08:48
Collaborator
|
@copilot Fix merge conflicts |
Co-authored-by: peters <869+peters@users.noreply.github.com>
Contributor
Author
Merge conflicts have been successfully resolved in commit 2e66342. The macOS support changes have been integrated with the latest develop branch while maintaining full compatibility with existing Windows and Linux functionality. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
peters
requested changes
Sep 19, 2025
… add macOS GitHub Actions Co-authored-by: peters <869+peters@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds complete macOS support to the snapx deployment tool, enabling cross-platform application deployment on macOS alongside existing Windows and Linux support.
Overview
The implementation follows the existing platform architecture pattern, extending the current Windows/Linux support to include native macOS functionality. All changes are backward compatible and don't affect existing Windows or Linux deployments.
Key Features Added
macOS Platform Integration
OSPlatform.OSXdetection throughout the C# codebaseSnapOsSpecialFoldersMacOSwith proper macOS folder paths:StartupDirectory:~/Library/LaunchAgentsfor autostart applicationsStartMenu:/Applicationsfor installed applicationsNative macOS Application Support
.appbundles with Info.plist filesCross-Platform Build System
osx-x64andosx-arm64Runtime Identifiers (RIDs).dylibextensions (vs.soon Linux)C++ Platform Abstraction Layer (PAL)
PAL_PLATFORM_MACOSplatform definepal_is_macos(), etc.)GitHub Actions CI/CD Support
macosjob withmacos-latestrunnersosx-x64andosx-arm64architecturesBootstrap-Unixtarget.dylibextensionsTechnical Implementation
The solution extends the existing
ISnapOsImplinterface with a newSnapOsMacOSclass that provides:The C++ PAL layer properly detects macOS at compile time:
Code Quality & Standards
namespace Snap.Tests.AnyOS.MacOS;)Merge Integration
Successfully resolved merge conflicts with the develop branch while maintaining full macOS functionality:
if(APPLE)conditionpal_sleep_ms()and addedpal_is_macos()functionpal_is_unknown_os()to recognize macOS as a known platformTesting
#if PLATFORM_MACOSX)Compatibility
This implementation enables snapx to deploy applications natively on macOS with proper system integration, app bundle creation, autostart capabilities, and continuous integration support while maintaining full compatibility with existing Windows and Linux deployments.
Fixes #429.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.