Skip to content

fix: storage.yml FTL cron #15609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncooke3 merged 5 commits into from
Dec 16, 2025
Merged

fix: storage.yml FTL cron #15609

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c616a9
fix: storage.yml FTL cron
ncooke3 Dec 16, 2025
6d1f53c
Update storage.yml
ncooke3 Dec 16, 2025
c4f9d2f
fixes
ncooke3 Dec 16, 2025
fcd754a
Update .github/workflows/storage.yml
ncooke3 Dec 16, 2025
d6c0c4c
update
ncooke3 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 77 additions & 73 deletions .github/workflows/storage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,70 +26,70 @@ concurrency:
cancel-in-progress: true

jobs:
spm:
uses: ./.github/workflows/common.yml
with:
target: FirebaseStorageUnit
# spm:
# uses: ./.github/workflows/common.yml
# with:
# target: FirebaseStorageUnit

catalyst:
uses: ./.github/workflows/common_catalyst.yml
with:
product: FirebaseStorage
target: FirebaseStorage-Unit-unit
# catalyst:
# uses: ./.github/workflows/common_catalyst.yml
# with:
# product: FirebaseStorage
# target: FirebaseStorage-Unit-unit

storage-integration-tests:
# Don't run on private repo unless it is a PR.
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
strategy:
matrix:
language: [Swift, ObjC]
include:
- os: macos-15
xcode: Xcode_16.4
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
- name: Setup Bundler
run: scripts/setup_bundler.sh
- name: Install xcpretty
run: gem install xcpretty
- name: Install Secret GoogleService-Info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/storage-db-plist.gpg \
FirebaseStorage/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret"
- name: Install Credentials.h
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Storage/Credentials.h.gpg \
FirebaseStorage/Tests/ObjCIntegration/Credentials.h "$plist_secret"
- name: Install Credentials.swift
run: |
scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Storage/Credentials.swift.gpg \
FirebaseStorage/Tests/Integration/Credentials.swift "$plist_secret"
- name: Xcode
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
- uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
with:
timeout_minutes: 15
max_attempts: 3
retry_wait_seconds: 120
command: ([ -z $plist_secret ] || scripts/build.sh Storage${{ matrix.language }} all)
# storage-integration-tests:
# # Don't run on private repo unless it is a PR.
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
# strategy:
# matrix:
# language: [Swift, ObjC]
# include:
# - os: macos-15
# xcode: Xcode_16.4
# env:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# runs-on: ${{ matrix.os }}
# steps:
# - uses: actions/checkout@v4
# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
# - name: Setup Bundler
# run: scripts/setup_bundler.sh
# - name: Install xcpretty
# run: gem install xcpretty
# - name: Install Secret GoogleService-Info.plist
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/storage-db-plist.gpg \
# FirebaseStorage/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret"
# - name: Install Credentials.h
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Storage/Credentials.h.gpg \
# FirebaseStorage/Tests/ObjCIntegration/Credentials.h "$plist_secret"
# - name: Install Credentials.swift
# run: |
# scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Storage/Credentials.swift.gpg \
# FirebaseStorage/Tests/Integration/Credentials.swift "$plist_secret"
# - name: Xcode
# run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
# - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
# with:
# timeout_minutes: 15
# max_attempts: 3
# retry_wait_seconds: 120
# command: ([ -z $plist_secret ] || scripts/build.sh Storage${{ matrix.language }} all)

quickstart:
# TODO: See #12399 and restore Objective-C testing for Xcode 15 if GHA is fixed.
uses: ./.github/workflows/common_quickstart.yml
with:
product: Storage
setup_command: scripts/setup_quickstart_spm.sh storage
plist_src_path: scripts/gha-encrypted/qs-storage.plist.gpg
plist_dst_path: quickstart-ios/storage/GoogleService-Info.plist
run_tests: false
secrets:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# quickstart:
# # TODO: See #12399 and restore Objective-C testing for Xcode 15 if GHA is fixed.
# uses: ./.github/workflows/common_quickstart.yml
# with:
# product: Storage
# setup_command: scripts/setup_quickstart_spm.sh storage
# plist_src_path: scripts/gha-encrypted/qs-storage.plist.gpg
# plist_dst_path: quickstart-ios/storage/GoogleService-Info.plist
# run_tests: false
# secrets:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}

quickstart-ftl-cron-only:
# Don't run on private repo.
if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'
if: github.repository == 'Firebase/firebase-ios-sdk' # && github.event_name == 'schedule'
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
runs-on: macos-15
Expand All @@ -99,13 +99,17 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Setup Bundler
run: scripts/setup_bundler.sh
- name: Install xcpretty
run: gem install xcpretty
- name: Xcode
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
- name: Setup quickstart
run: scripts/setup_quickstart.sh storage
run: QUICKSTART_BRANCH=nc/strg-tests scripts/setup_quickstart_spm.sh storage
- name: Install Secret GoogleService-Info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \
quickstart-ios/storage/GoogleService-Info.plist "$plist_secret"
# - name: Build objc quickstart
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Storage)
- name: Build swift quickstart
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Storage swift)
- id: ftl_test
Expand All @@ -115,16 +119,16 @@ jobs:
testapp_dir: quickstart-ios/build-for-testing
test_type: "xctest"

pod_lib_lint:
uses: ./.github/workflows/common_cocoapods.yml
with:
product: FirebaseStorage
test_specs: unit
# pod_lib_lint:
# uses: ./.github/workflows/common_cocoapods.yml
# with:
# product: FirebaseStorage
# test_specs: unit

storage-cron-only:
needs: pod_lib_lint
uses: ./.github/workflows/common_cocoapods_cron.yml
with:
product: FirebaseStorage
platforms: '[ "ios", "tvos", "macos", "watchos" ]'
flags: '[ "--use-static-frameworks --skip-tests" ]'
# storage-cron-only:
# needs: pod_lib_lint
# uses: ./.github/workflows/common_cocoapods_cron.yml
# with:
# product: FirebaseStorage
# platforms: '[ "ios", "tvos", "macos", "watchos" ]'
# flags: '[ "--use-static-frameworks --skip-tests" ]'
Loading