feat(py): add embedder reference support matching JS SDK #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add EmbedderRef, EmbedderOptions, and EmbedderSupports types to enable referencing embedders with specific configurations, matching the Go SDK functionality. BREAKING CHANGE: define_embedder() now accepts 'options: EmbedderOptions' parameter instead of separate 'config_schema' parameter. Changes: - Add EmbedderRef, EmbedderOptions, EmbedderSupports types to embedding.py - Implement embed() method in Genkit class supporting EmbedderRef - Update define_embedder signature to accept EmbedderOptions parameter - Fix circular imports using TYPE_CHECKING and proper import organization - Add to_json_schema() conversions for all config_schema usages - Update all plugins (OpenAI, Google GenAI, Ollama) to use JSON schemas - Add comprehensive tests for embedder functionality - Update test assertions to match new schema conversion behavior
hendrixmar
approved these changes
Dec 12, 2025
yesudeep
reviewed
Dec 12, 2025
yesudeep
requested changes
Dec 12, 2025
yesudeep
changed the title
yesudeep
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add EmbedderRef, EmbedderOptions, and EmbedderSupports types to enable referencing embedders with specific configurations, matching the Go SDK functionality.
BREAKING CHANGE: define_embedder() now accepts 'options: EmbedderOptions' parameter instead of separate 'config_schema' parameter.
CHANGELOG:
define_embedder()to accept EmbedderOptions parameter