feat: interactively filter bank chart #239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amliu-jumptrading
requested review from
asuzuki-jumptrading and
atsai-jumptrading
amliu-jumptrading
force-pushed
the
amliu/slotdetail-interaction
branch
from
f1bc2f6 to
6afdd23
Compare
amliu-jumptrading
force-pushed
the
amliu/slotdetail-interaction
branch
3 times, most recently
from
05f02f6 to
7ada83d
Compare
| > | ||
| <Command.Input | ||
| placeholder={dropdownPlaceholderText[search.mode]} | ||
| onClick={() => setIsOpen(true)} |
Collaborator
Author
There was a problem hiding this comment.
We want the options list to stay hidden when the search input is focussed because of an external trigger (clicking on the distribution bar), but open when the user interacts with it. I wasn't able to find a simple way to distinguish programatic focus vs user interaction focus, so I broke down user interaction into the specific ones we want to trigger opening the options list: click (mouse and touch) and enter keydown (keyboard).
amliu-jumptrading
force-pushed
the
amliu/slotdetail-interaction
branch
from
7ada83d to
359a0f4
Compare
asuzuki-jumptrading
force-pushed
the
amliu/navigation1
branch
from
a5ef8c3 to
b3cbeab
Compare
amliu-jumptrading
force-pushed
the
amliu/slotdetail-interaction
branch
from
359a0f4 to
9d96971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added interactivity to the distribution bars in the Fees section of the slot detail stats
Added affordances to indicate which distribution bars are interactable (y-axis transform, brightness filter, outline)
Added tooltip and outline to chart control that got updated by an external trigger (clicking on the distribution bars)