Skip to content

tower: only count completely successful votes from replay #8086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yufeng-jump wants to merge 1 commit into
base: yufeng/replay-txn
Choose a base branch
from
Open

tower: only count completely successful votes from replay #8086

yufeng-jump wants to merge 1 commit into from
+11 −14

Conversation

@yufeng-jump
Copy link
Contributor

@yufeng-jump yufeng-jump commented Jan 29, 2026

No description provided.

yufeng-jump
yufeng-jump commented Jan 29, 2026
View reviewed changes
mmcgee-jump
mmcgee-jump reviewed Jan 29, 2026
View reviewed changes
mmcgee-jump
mmcgee-jump requested changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@mmcgee-jump mmcgee-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.069914 s 0.069997 s 0.119% ✅
backtest mainnet-368528500-perf snapshot load NaN s NaN s NaN% ✅
backtest mainnet-368528500-perf total elapsed 69.913723 s 69.997136 s 0.119% ✅
firedancer mem usage with mainnet.toml 1008.31 GiB 1009.29 GiB 0.097% ✅

@yufeng-jump yufeng-jump force-pushed the yufeng/tower-snoop-exec-vote branch from 5e9a23a to 13f8e7c Compare February 11, 2026 00:43
@yufeng-jump yufeng-jump changed the base branch from main to yufeng/replay-txn February 11, 2026 00:44
@yufeng-jump yufeng-jump removed the request for review from ptaffet-jump February 11, 2026 00:49
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.052472 s 0.052452 s -0.038% ✅
backtest mainnet-368528500-perf snapshot load 2.477 s 1.684 s -32.015% ✅
backtest mainnet-368528500-perf total elapsed 52.471626 s 52.4522 s -0.037% ✅
firedancer mem usage with mainnet.toml 1003.33 GiB 1000.3 GiB -0.302% ✅

@yufeng-jump yufeng-jump changed the title tower: only count votes from execrp post sigverify tower: only count completely successful votes from replay Feb 11, 2026
@yufeng-jump yufeng-jump force-pushed the yufeng/tower-snoop-exec-vote branch from 13f8e7c to 496a4b5 Compare February 12, 2026 04:08
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.052066 s 0.052134 s 0.131% ✅
backtest mainnet-368528500-perf snapshot load 2.441 s 1.815 s -25.645% ✅
backtest mainnet-368528500-perf total elapsed 52.066411 s 52.133641 s 0.129% ✅
firedancer mem usage with mainnet.toml 987.33 GiB 984.3 GiB -0.307% ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidatong lidatong lidatong left review comments

@mmcgee-jump mmcgee-jump mmcgee-jump requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yufeng-jump @lidatong @mmcgee-jump