runtime: simplify bank object initialization #8258
Open
+148
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
ripatel-fd
force-pushed
the
bank-mgr-refs
branch
from
9aeff45 to
456fc5e
Compare
Performance Measurements ⏳
|
ripatel-fd
force-pushed
the
bank-mgr-refs
branch
from
456fc5e to
76c92ac
Compare
Simplifies addressing of objects that are shared across multiple banks. For convenience, each bank retains position-independent pointers to objects managed by fd_banks. Since the difference between (bank[i]-fd_banks) and (bank[i]<->cost_tracker) is constant for each i, each bank only needs to store a pointer to fd_banks. Also, we remove the assumption that certain bank fields are retained while the bank is in the free pool. (All fields are initialized on bank object creation now.) This allows us to install stronger UAF detection using MSan.
Don't rely on partially-initialized structs, allowing us to add MSan support.
Simplifies plumbing of a benchmark/development option Also fix initialization of the cost tracker object
ripatel-fd
force-pushed
the
bank-mgr-refs
branch
from
76c92ac to
0151238
Compare
ripatel-fd
changed the title
ripatel-fd
changed the title
Performance Measurements ⏳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies addressing of objects that are shared across multiple
banks. For convenience, each bank retains position-independent
pointers to objects managed by fd_banks. Since the difference
between (bank[i]-fd_banks) and (bank[i]<->cost_tracker) is constant
for each i, each bank only needs to store a pointer to fd_banks.
Also, we remove the assumption that certain bank fields are
retained while the bank is in the free pool. (All fields are
initialized on bank object creation now.) This allows us to install
stronger UAF detection using MSan.